refactor(useDownloadLink): Move useDetectOs to useDownloadLink #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Harkunwar
commented
May 12, 2023
Harkunwar
commented
May 13, 2023
Harkunwar
commented
May 13, 2023
Harkunwar
commented
May 13, 2023
Harkunwar
changed the title
Contributor
|
I think we can remove the |
ovflowd
reviewed
May 14, 2023
ovflowd
reviewed
May 14, 2023
Harkunwar
force-pushed
the
refactor/use-download-link
branch
from
1b05b01 to
7dc5791
Compare
ovflowd
added a commit
that referenced
this pull request
May 17, 2023
* test(snapshot): Migrate snapshot tests to storybook (#5340) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> fixed styleling misconfig and fixed storybooks (#5281) fix storybook styles, imports, typescript config and dependencies (#5319 fix(package.json) Lint command is missing slashes (#5321 fix storybook local development mode (#5335) fix(i18n): translation key (#5347) * chore: no-unused-vars ignores pattern starting with _ (#5363) * Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369) Add clarity to step 4 based on clone method Signed-off-by: Vessy Shestorkina <[email protected]> * fix(test): dir name (#5354) * feat(stability): migrate component (#5339) * Migrate JsonLink component (#5370) * Migrate JsonLink component Signed-off-by: Vessy Shestorkina <[email protected]> * Add storybook snap and robot icon Signed-off-by: Vessy Shestorkina <[email protected]> * Remove IconContext provider Signed-off-by: Vessy Shestorkina <[email protected]> --------- Signed-off-by: Vessy Shestorkina <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376) * refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: Add MUI Config and Theme Provider (#5368) * feat: Add MUI Config and Theme Provider * added createTheme * refactor themeConfig * feat(theme): Fix linting and package-lock * feat(theme): Add emotion styled and emtion react --------- Co-authored-by: Harkunwar Kochar <[email protected]> * refactor(delete): duplicate test file (#5377) refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <[email protected]> * feat(useClickOutside): introduce (#5359) * feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: build --------- Signed-off-by: Augustin Mauroy <[email protected]> Signed-off-by: Harkunwar Kochar <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> --------- Signed-off-by: Vessy Shestorkina <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> Signed-off-by: Harkunwar Kochar <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> Co-authored-by: Vessy <[email protected]> Co-authored-by: Mert Can Altın <[email protected]>
ovflowd
added a commit
that referenced
this pull request
May 24, 2023
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>
ovflowd
added a commit
that referenced
this pull request
May 24, 2023
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored this hook because it seems like the hook does something which isn't obvious from the name, which is mainly to get the download link for Node JS.
detectOSis already a quick synchronous function so it doesn't make sense to have a hook to do the same either. Moreover, we're usinguseEffectwhen we don't need to, and it's bad for performance. We should avoid it whenever we can. Lastly, we should useswrfor all async for better error handling. This PR also adds types fornavigatorso we don't need to ignore them and can be fully type safe.Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.